New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd/bench: fix write gaps when doing sequential writes with io-threads > 1 #15206

Merged
merged 1 commit into from May 24, 2017

Conversation

Projects
None yet
3 participants
@ifed01
Contributor

ifed01 commented May 22, 2017

…ads > 1

Signed-off-by: Igor Fedotov ifedotov@mirantis.com
Signed-off-by: Mykola Golub mgolub@mirantis.com

@ifed01 ifed01 added the bug fix label May 22, 2017

@trociny trociny added the rbd label May 23, 2017

break;
}

This comment has been minimized.

@trociny

trociny May 23, 2017

Contributor

@ifed01 lgtm, Just a suggestion to consider though.
Don't you think the code would look a little nicer if instead of old_offs we introduced a variable that would store the new calculated offset (e.g. thread_off)? Then instead of updating thread_offset[i] before start_io, we would set this thread_off, pass it to start_io, and update thread_offset[i] onfly if start_io succeeded.

This comment has been minimized.

@ifed01

ifed01 May 23, 2017

Contributor

@trociny - just committed even nicer fix - no need to update thread_offset before i/o submission..

@trociny trociny changed the title from rbd/bench: fixes write gaps when doing sequential writes with io-thre… to rbd/bench: fix write gaps when doing sequential writes with io-threads > 1 May 23, 2017

Igor Fedotov
rbd/bench: fixes write gaps when doing sequential writes with io-thre…
…ads > 1

Signed-off-by: Igor Fedotov <ifedotov@mirantis.com>
Signed-off-by: Mykola Golub mgolub@mirantis.com
@trociny

lgtm

@trociny trociny merged commit 1d74182 into ceph:master May 24, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@ifed01 ifed01 deleted the ifed01:wip-fix-rbd-bench branch May 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment