New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix factual inaccuracy in doc/architecture.rst #15235

Merged
merged 2 commits into from May 25, 2017

Conversation

Projects
None yet
4 participants
@smithfarm
Contributor

smithfarm commented May 23, 2017

Signed-off-by: Sage Weil sage@redhat.com
Signed-off-by: Nathan Cutler ncutler@suse.com

@smithfarm smithfarm requested review from liewegas and johnwilkins May 23, 2017

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented May 23, 2017

@liewegas I wasn't sure which of these two statements is inaccurate: "The Ceph Monitor can ping a Ceph OSD Daemon periodically to ensure that it is running" or "Ceph also empowers Ceph OSD Daemons to determine if a neighboring OSD is down, to update the cluster map and to report it to the Ceph monitor(s)" (or both?)

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented May 23, 2017

This relates to @liewegas 's recent email to ceph-devel mailing list, Subject: Re: Which function is mon ping osd?

This means that Ceph Monitors can remain lightweight processes. See
`Monitoring OSDs`_ and `Heartbeats`_ for additional details.
#. **Data Scrubbing:** As part of maintaining data consistency and cleanliness,

This comment has been minimized.

@tchaikov

tchaikov May 23, 2017

Contributor

weird, i cannot identify the delta in this paragraph.

This comment has been minimized.

@smithfarm

smithfarm May 23, 2017

Contributor

sorry, there's no delta in the Data Scrubbing paragraph - I think it was just a whitespace change. Sorry, fixing.

OSD is ``down``, to update the cluster map and to report it to the Ceph
monitor(s). This means that Ceph monitors can remain light weight processes.
Daemon cannot notify the Ceph Monitor that it is ``down``. The OSDs
periodically send messages to the Ceph Monitor (``pg stats`` pre-luminous,

This comment has been minimized.

@tchaikov

tchaikov May 23, 2017

Contributor

maybe, s/pg stats/MPGStats/ to be more symmetric ? as MOSDBeacon is a message type. but i am fine either way.

This comment has been minimized.

@liewegas

liewegas May 23, 2017

Member

yeah that's be better. otherwise lgtm, ok to merge with that change!

@liewegas

This comment has been minimized.

Member

liewegas commented May 23, 2017

Mostly teh second, but this is better: "Normally Ceph OSD Daemons determine if a neighboring OSD is down and to report it to the Ceph monitor(s)." The mon marknig down due to a missing beacon is a fail safe (if, say, all osds are down), and very slow.

@ceph-jenkins

This comment has been minimized.

Collaborator

ceph-jenkins commented May 23, 2017

all commits in this PR are signed

@ceph-jenkins

This comment has been minimized.

Collaborator

ceph-jenkins commented May 23, 2017

submodules for project are unmodified

@smithfarm

This comment has been minimized.

Contributor

smithfarm commented May 23, 2017

@liewegas Please check out the commit I just added. I also made the change suggested by @tchaikov.

smithfarm added some commits May 23, 2017

doc: fix factual inaccuracy in doc/architecture.rst
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Nathan Cutler <ncutler@suse.com>
doc: doc/architecture.rst: unify initial caps in term Ceph Monitor
Signed-off-by: Nathan Cutler <ncutler@suse.com>

@smithfarm smithfarm merged commit 9e29768 into ceph:master May 25, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@smithfarm smithfarm deleted the smithfarm:wip-doc-empowers branch May 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment