New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: write "mkfs_done" into disk only if we pass fsck() tests #15238

Merged
merged 1 commit into from May 24, 2017

Conversation

Projects
None yet
3 participants
@xiexingguo
Member

xiexingguo commented May 23, 2017

In our local test bed, we found mkfs() sometimes can fail
due to errors discovered by fsck(), and is therefore unrecoverable
by redoing mkfs() as the "mkfs_done" flag has been already successfully saved into disk.

This patch fixes the above case.

Signed-off-by: xie xingguo xie.xingguo@zte.com.cn

@xiexingguo xiexingguo changed the title from os/bluestore: allow redo mkfs if fsck() failed to os/bluestore: write "mkfs_done" into disk only if we pass fsck() tests May 23, 2017

os/bluestore: save "mkfs_done" only if we pass fsck() tests
In our local test bed, we found mkfs() sometimes can fail
due to errors discovered by fsck(), and is therefore unrecoverable
by redoing mkfs() as the "mkfs_done" flag has been successfully saved into disk.

This patch fixes the above case.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

@liewegas liewegas merged commit ba3e590 into ceph:master May 24, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@xiexingguo xiexingguo deleted the xiexingguo:wip-fix-blue-mkfs branch May 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment