Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg: don't set msgr addr when disabing client bind #15243

Merged
merged 1 commit into from Jun 7, 2017

Conversation

Projects
None yet
3 participants
@yuyuyu101
Copy link
Member

yuyuyu101 commented May 23, 2017

if disabling client bind, client side will send handshake message with blank
ip. so the server side will ignore this.

otherwise, server side decide to learn this addr which isn't the expected addr

Signed-off-by: Haomai Wang haomai@xsky.com

msg: don't set msgr addr when disabing client bind
if disabling client bind, client side will send handshake message with blank
ip. so the server side will ignore this.

otherwise, server side decide to learn this addr which isn't the expected addr

Signed-off-by: Haomai Wang <haomai@xsky.com>
@dillaman

This comment has been minimized.

Copy link
Contributor

dillaman commented May 24, 2017

@yuyuyu101 How would this fix the issue? On the client-side, I cannot assume ms_bind_before_connect is false (it defaults to true) which will result in the connection blocking forever due to the incorrect binding of an incorrectly learned local IP address.

For example, the OpenStack os-brick project writes its own ceph.conf file (for some reason) [1] so an admin would have no way to disable this new behavior (devstack runs tempest tests under jewel, fails on master)

[1] https://github.com/openstack/os-brick/blob/stable/ocata/os_brick/initiator/connectors/rbd.py#L72

@yuyuyu101

This comment has been minimized.

Copy link
Member Author

yuyuyu101 commented May 25, 2017

what about set to false by default?

@dillaman

This comment has been minimized.

Copy link
Contributor

dillaman commented May 25, 2017

@yuyuyu101 That would be fine with me

@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Jun 6, 2017

ready for merge @yuyuyu101 @dillaman @liewegas

@yuyuyu101 yuyuyu101 merged commit c41ab15 into ceph:master Jun 7, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@yuyuyu101 yuyuyu101 deleted the yuyuyu101:wip-20049 branch Jun 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.