New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osdmaptool: require --upmap-save before modifying input osdmap #15247

Merged
merged 1 commit into from May 26, 2017

Conversation

Projects
None yet
1 participant
@liewegas
Member

liewegas commented May 23, 2017

IMO it is dangerous to modify the provided osdmap in this case unless the
user explicitly asks for it. This was super annoying while I was testing
this code.

Signed-off-by: Sage Weil sage@redhat.com

osdmaptool: require --upmap-save before modifying input osdmap
IMO it is dangerous to modify the provided osdmap in this case unless the
user explicitly asks for it.  This was super annoying while I was testing
this code.

Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas

This comment has been minimized.

@liewegas

This comment has been minimized.

Member

liewegas commented May 26, 2017

@dachary does this make sense?

@ghost

ghost approved these changes May 26, 2017

@liewegas liewegas merged commit 622c09c into ceph:master May 26, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@liewegas liewegas deleted the liewegas:wip-upmap-save branch May 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment