New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: Remove redundant includes - 5 #15267

Merged
merged 1 commit into from Jun 1, 2017

Conversation

Projects
None yet
5 participants
@joscollin
Member

joscollin commented May 24, 2017

Fixes: http://tracker.ceph.com/issues/19883 (Partially)

Signed-off-by: Jos Collin jcollin@redhat.com

@joscollin

This comment has been minimized.

Member

joscollin commented May 24, 2017

Jenkins Retest this please

@badone

This comment has been minimized.

Contributor

badone commented May 25, 2017

Jenkins retest this please

@yuriw

This comment has been minimized.

Contributor

yuriw commented May 26, 2017

suspect this PR broke build


In file included from /build/ceph-12.0.2-1634-gb690355/src/rgw/rgw_file.h:31:0,
                 from /build/ceph-12.0.2-1634-gb690355/src/test/librgw_file_nfsns.cc:23:
/build/ceph-12.0.2-1634-gb690355/src/common/ceph_timer.h:62:5: error: field 'schedule_link' has incomplete type
  sh schedule_link;

in

https://jenkins.ceph.com/job/ceph-dev-new-build/ARCH=x86_64,AVAILABLE_ARCH=x86_64,AVAILABLE_DIST=trusty,DIST=trusty,MACHINE_SIZE=huge/3577//consoleFull

common: Remove redundant includes
Fixes: http://tracker.ceph.com/issues/19883 (Partially)

Signed-off-by: Jos Collin <jcollin@redhat.com>

@tchaikov tchaikov requested a review from wjwithagen May 26, 2017

@wjwithagen

@joscollin @liewegas @yuriw

This reorganisation set is oke, Compiles oke, and tests are no different then without patch.

@badone badone removed the needs-qa label Jun 1, 2017

@badone badone merged commit 569125c into ceph:master Jun 1, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@joscollin joscollin deleted the joscollin:wip-cleanup-redundant-headers-5 branch Jun 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment