Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do_cmake.sh: enable ccache if installed #15274

Merged
merged 1 commit into from Jun 1, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Copy link
Member

liewegas commented May 24, 2017

Signed-off-by: Sage Weil sage@redhat.com

@liewegas liewegas added the build/ops label May 24, 2017

do_cmake.sh Outdated
ARGS=""
if which ccache ; then
echo "enabling ccache"
ARGS+="-DWITH_CCACHE=On"

This comment has been minimized.

Copy link
@tchaikov

tchaikov May 27, 2017

Contributor

maybe we can use ON, see https://cmake.org/cmake/help/v3.0/command/if.html

True if the constant is 1, ON, YES, TRUE, Y, or a non-zero number.

@tchaikov
Copy link
Contributor

tchaikov left a comment

lgtm aside from the nit

do_cmake.sh: enable ccache if installed
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas force-pushed the liewegas:wip-auto-ccache branch from 643803c to f251b07 Jun 1, 2017

@liewegas liewegas merged commit ff2d625 into ceph:master Jun 1, 2017

0 of 3 checks passed

Signed-off-by checking if commits are signed
Details
Unmodifed Submodules checking if PR has modified submodules
Details
default Build started sha1 is merged.
Details

@liewegas liewegas deleted the liewegas:wip-auto-ccache branch Jun 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.