Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds: change the type of data_pools #15278

Merged
merged 2 commits into from Jun 1, 2017

Conversation

Projects
None yet
3 participants
@viCEnTECheNg
Copy link
Contributor

viCEnTECheNg commented May 25, 2017

In following scenario, we found something strange here.

Here we have two pools as following:

- data_pool1    id: 20
- data_pool2    id: 21

First, we create ceph fs with data_pool2 and default data_pool is data_pool2.
Then, add the new data pool data_pool1.
Now, the default data_pool will be data_pool1.

Because set will sort, we can't remain the default data_pool as we wish.
(we assume that the default data_pool should be the data_pool that we create cephfs)

It seems vector is more suitable than set.

viCEnTECheNg added some commits May 23, 2017

mds: change the type of data_pools
	Change the type of data_pools from `set` to `vector`

	In following scenario, we found something strange here.

	Here we have two pools as following:

		- data_pool1    id: 20
		- data_pool2    id: 21

	First, we create ceph fs with `data_pool2` and default data_pool is `data_pool2`.
	Then, add the new data pool `data_pool1`.
	Now, the default data_pool will be data_pool1.

	Because set will sort, we can't remain the default data_pool as we wish.
	(we assume that the default data_pool should be the data_pool that we create cephfs)

	It seems vector is more suitable than set.

Signed-off-by: Vicente Cheng <vicente_cheng@bigtera.com>
cephfs: Add some check befor we want to add new data pool
Signed-off-by: Vicente Cheng <vicente_cheng@bigtera.com>
@ukernel

This comment has been minimized.

Copy link
Member

ukernel commented May 25, 2017

LGTM

@jcsp

jcsp approved these changes May 25, 2017

@jcsp jcsp merged commit 78a17fb into ceph:master Jun 1, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@viCEnTECheNg viCEnTECheNg deleted the viCEnTECheNg:wip-data-pools-type branch Jun 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.