New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Rename FileJournal object to distinguish #15279

Merged
merged 1 commit into from May 25, 2017

Conversation

Projects
None yet
2 participants
@joscollin
Member

joscollin commented May 25, 2017

Renamed FileJournal object for easier searching and identifying with in
test_filejournal.cc. This difficulty is found while reviewing
#15266. Avoid using Single Character Object Names.

Signed-off-by: Jos Collin jcollin@redhat.com

test: Rename FileJournal object to distinguish
Renamed FileJournal object for easier searching and identifying with in test_filejournal.cc

Signed-off-by: Jos Collin <jcollin@redhat.com>

@joscollin joscollin requested a review from adamemerson May 25, 2017

@joscollin joscollin added the cleanup label May 25, 2017

@adamemerson

Lebesgue Gave a Trusty Measure

@@ -120,9 +120,9 @@ TEST(TestFileJournal, Create) {
for (unsigned i = 0 ; i < 3; ++i) {
SCOPED_TRACE(subtests[i].description);
fsid.generate_random();
FileJournal j(g_ceph_context, fsid, finisher, &sync_cond, path,
FileJournal fj(g_ceph_context, fsid, finisher, &sync_cond, path,
subtests[i].directio, subtests[i].aio, subtests[i].faio);

This comment has been minimized.

@adamemerson

adamemerson May 25, 2017

Contributor

Seems useful enough and there aren't really any downsides.

@joscollin joscollin merged commit 4ef5559 into ceph:master May 25, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@joscollin

This comment has been minimized.

Member

joscollin commented May 25, 2017

@adamemerson Thank you for the approval. This is indeed useful. The names can be bigger like filejournal. But as fg is unique inside test_filejournal.cc this fixes the problem. Merged now.

@joscollin joscollin deleted the joscollin:wip-cleanup-rename-filejournal-object branch May 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment