New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds: Pass empty string to clear mantle balancer #15282

Merged
merged 2 commits into from Jun 1, 2017

Conversation

Projects
None yet
2 participants
@david-z
Member

david-z commented May 25, 2017

Currently we can use ceph fs set cephfs balancer <lua_conf_file> to set mantle balancer. Then MDS balancer will try to use this mantle balancer firstly if MDS finds its balancer is not empty when handling hearbeat. If we want to switch back to old balancer, we need to set balancer to some strings which means an non-existed lua file to let MDS failing to reload it. But MDS still has to try reloading this non-existed lua file from OSD every time.

Within this fix, ceph fs set can pass empty string to clear mantle balancer.

ceph fs set cephfs balancer ""

Fixes: #http://tracker.ceph.com/issues/20076

Signed-off-by: Zhi Zhang zhangz.david@outlook.com

@david-z

This comment has been minimized.

Member

david-z commented May 25, 2017

Hi Guys,

I also included a minor fix for message ref leak in this PR. Pls let me know if you think it is better to open another PR for it. Thanks.

@jcsp

This comment has been minimized.

Contributor

jcsp commented May 25, 2017

Was ceph fs set cephfs balancer "" not working? I would rather make that work than add a separate command.

Zhi Zhang added some commits May 25, 2017

Zhi Zhang
Pass empty string to clear mantle balancer
Signed-off-by: Zhi Zhang <zhangz.david@outlook.com>
Zhi Zhang
mds/MDBalancer: put heartbeat msg ref after using mantle balancer
Signed-off-by: Zhi Zhang <zhangz.david@outlook.com>

@david-z david-z changed the title from mantle: add clear_balancer sub-command to unset mantle balancer to Pass empty string to clear mantle balancer May 26, 2017

@david-z

This comment has been minimized.

Member

david-z commented May 26, 2017

@jcsp Good suggestion. Original ceph fs set cephfs balancer "" was not working because empty string can't be passed into FSCommand handler. Within this fix, it can work now. Pls help to review, thanks.

@jcsp

jcsp approved these changes May 26, 2017

@liewegas liewegas changed the title from Pass empty string to clear mantle balancer to mds: Pass empty string to clear mantle balancer May 30, 2017

@jcsp jcsp merged commit 284c96f into ceph:master Jun 1, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment