New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: describe CephFS max_file_size #15287

Merged
merged 2 commits into from May 26, 2017

Conversation

Projects
None yet
4 participants
@ktdreyer
Member

ktdreyer commented May 25, 2017

Add a description of max_file_size to the CephFS admin docs.

Thanks to John Spray jspray@redhat.com on ceph-users for this information.

@ktdreyer ktdreyer requested review from jcsp and gregsfortytwo May 25, 2017

When users create a file of an enormous size (without necessarily
writing any data to it), some operations (such as deletes) cause the MDS
to have to do a ridiculously large number of operations to check if any

This comment has been minimized.

@alfredodeza

alfredodeza May 25, 2017

Contributor

I don't think you need to point out that the number is ridiculously large. s/ridiculously//g reads OK to me

@jcsp

This comment has been minimized.

Contributor

jcsp commented May 25, 2017

This neatly captures what I wrote on the mailing list, but it's perhaps too much detail for the user docs -- the middle three paragraphs are more of an architectural explanation of why the field exists, it could confuse people.

If you want to keep that text, I'd bump it to the bottom or put it in an info/background sidebar.

@vasukulkarni

This comment has been minimized.

Member

vasukulkarni commented May 25, 2017

👍

@ktdreyer

This comment has been minimized.

Member

ktdreyer commented May 25, 2017

@jcsp I've moved the paragraphs to a new "Maximum file sizes and performance" section. Trying to help users understand the implications of raising the limit.

@jcsp

This comment has been minimized.

Contributor

jcsp commented May 26, 2017

👍 just needs a Signed-off-by line on the commit that doesn't have one.

ktdreyer added some commits May 25, 2017

doc: describe CephFS max_file_size
Add a description of max_file_size to the CephFS admin docs.

Thanks to John Spray <jspray@redhat.com> on ceph-users for this
information.

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
doc: describe differences with "mds set" vs "fs set"
Thanks to John Spray <jspray@redhat.com> on ceph-users for this
information.

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>

@jcsp jcsp merged commit ba545c1 into ceph:master May 26, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@ktdreyer ktdreyer deleted the ktdreyer:doc-ceph-fs-settings branch May 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment