New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: Fixed typo in function comment blocks and in other comments #15304

Merged
merged 1 commit into from May 26, 2017

Conversation

Projects
None yet
5 participants
@Linbing

Linbing commented May 26, 2017

I found there is a lot of iif error of note, so i grep it and modify all in project

Signed-off-by: linbing linbing@t2cloud.net

linbing
Modify note error
Signed-off-by: linbing linbing@t2cloud.net
@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented May 26, 2017

@Linbing iff means if and only if.

@branch-predictor

Exactly what @Liuchang0812 wrote, these "iifs" are correct and don't require changes.

@Linbing

This comment has been minimized.

Linbing commented May 26, 2017

@branch-predictor

This comment has been minimized.

Member

branch-predictor commented May 26, 2017

@Linbing the actual error is that it's "iff" (http://mathworld.wolfram.com/Iff.html), not "iif", but please use common sense here. For non-mathematicians it may be obvious typo, but common sense says if same typo occurs so often, it cannot be just a typo.

@joscollin

This comment has been minimized.

Member

joscollin commented May 26, 2017

@Linbing @Liuchang0812 @branch-predictor

You are changing from iif to if, which is correct. The PR#15191 is also correctly fixed. I think you people are confusing yourself. Please check again.

@joscollin

This comment has been minimized.

Member

joscollin commented May 26, 2017

@branch-predictor These headers are probably copy-pasted and then modified for each function, in-order to keep the same format / alignment for all functions. Also the programmer doesn't have type "@pre", "@post" or "@param" repeatedly. As a consequence, the mistake iif is also copied.

@joscollin

LGTM

@joscollin joscollin changed the title from Modify note error to mon: Fixed typo in function comment blocks and in other comments May 26, 2017

@joscollin joscollin merged commit cc2780c into ceph:master May 26, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented May 26, 2017

@joscollin next time, when you are merging a PR, could you add a Reviewed-by line at the end of the merging commit?

@joscollin

This comment has been minimized.

Member

joscollin commented May 27, 2017

@tchaikov I will surely do that. Thanks for catching that.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented May 27, 2017

@Linbing
next time, could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes

@joscollin

This comment has been minimized.

Member

joscollin commented May 30, 2017

@tchaikov Is it Merged-by or Reviewed-by ? Please clarify. Thanks.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented May 30, 2017

Reviewed-by.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment