New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/tasks/ceph: raise exceptions if scrubbing fails or cannot proceed #15310

Merged
merged 7 commits into from Jun 16, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented May 26, 2017

No description provided.

@tchaikov tchaikov added the needs-qa label May 27, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented May 27, 2017

retest this please (jenkins failure)

@liewegas

This comment has been minimized.

Member

liewegas commented May 29, 2017

scrub_test.yaml shoudl skip scrub.

@liewegas

This comment has been minimized.

Member

liewegas commented May 29, 2017

http://pulpito.ceph.com/sage-2017-05-28_05:00:18-rados-wip-sage-testing---basic-smithi/1238310

and end of thrasher, need to wait for osds to be up, then flush pg stats, then wait for healthy.

@liewegas

This comment has been minimized.

Member

liewegas commented Jun 9, 2017

retest this please

liewegas added some commits May 26, 2017

qa/tasks/ceph: osd_scrub_pgs: try a bit longer
I just saw a test fail that was still waiting for
scrubs to complete.

Signed-off-by: Sage Weil <sage@redhat.com>
qa/tasks/ceph: raise an exception if pgs are not clean
If this happens the preceding test should have cleaned
up (e.g., ceph.healthy:).

Signed-off-by: Sage Weil <sage@redhat.com>
qa/tasks/ceph: raise exception if scrubs time out
Signed-off-by: Sage Weil <sage@redhat.com>
qa/suites/rados/basic/repair_test: skip final scrub
OSD is deliberately damaged; scrub will fail.

Signed-off-by: Sage Weil <sage@redhat.com>
@@ -1186,6 +1186,9 @@ def flush_pg_stats(self, osds, no_wait=None, wait_for_mon=3*5):
'osd.{osd}: {got} < {need}'.
format(osd=osd, got=got, need=need))
def flush_all_pg_stats(self):
self.flush_pg_stats(range(0, len(self.get_osd_dump())))

This comment has been minimized.

@tchaikov

tchaikov Jun 15, 2017

Contributor

nit, range(0, n) is equivalent to range(n)

liewegas added some commits May 31, 2017

qa/tasks/thrashosds: wait before wait_for_recovery
Make sure OSDs are up *and* they have flushed their PG stats before
waiting for recovery to ensure that we do not see a stale 'clean' state.

Signed-off-by: Sage Weil <sage@redhat.com>
qa/suites/rados/basic-luminous/scrub_test: skip final scrub
Signed-off-by: Sage Weil <sage@redhat.com>
qa/suites/rados/thrash/worklaods/radosbench: use less disk
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas added the needs-qa label Jun 15, 2017

@liewegas liewegas merged commit ca4b358 into ceph:master Jun 16, 2017

2 of 4 checks passed

arm64 make check arm64 make check failed
Details
make check make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details

@liewegas liewegas deleted the liewegas:wip-qa-scrubs branch Jun 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment