Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/OSDMonitor: cancel mapping job from update_from_paxos #15320

Merged
merged 1 commit into from May 28, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Copy link
Member

liewegas commented May 26, 2017

On the leader we cancel the mapping job in encode_pending. On a peon,
we don't cancel it at all! It is surprising this didn't already cause
problems, but with the PGtempMap is pretty reliably crashes with a
largish map.

Signed-off-by: Sage Weil sage@redhat.com

@liewegas liewegas added core mon labels May 26, 2017

@liewegas liewegas requested a review from tchaikov May 26, 2017

mon/OSDMonitor: cancel mapping job from update_from_paxos
On the leader we cancel the mapping job in encode_pending.  On a peon,
we don't cancel it at all!  It is surprising this didn't already cause
problems, but with the PGtempMap is pretty reliably crashes with a
largish map.

Fixes: http://tracker.ceph.com/issues/20067
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas force-pushed the liewegas:wip-peon-mapping branch from 9003fd2 to 2e6317a May 26, 2017

@liewegas

This comment has been minimized.

Copy link
Member Author

liewegas commented May 26, 2017

retest this please

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented May 27, 2017

i think this addresses http://tracker.ceph.com/issues/20067

@liewegas

This comment has been minimized.

@liewegas liewegas merged commit c562854 into ceph:master May 28, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@liewegas liewegas deleted the liewegas:wip-peon-mapping branch May 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.