New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw/rgw_op:Prevents memory leaks when calling func swift_versioning_copy() fails #15328

Merged
merged 1 commit into from Jun 12, 2017

Conversation

Projects
None yet
3 participants
@jimifm
Contributor

jimifm commented May 27, 2017

Signed-off-by: jimifm hong.zhangoole@gmail.com

@jimifm jimifm closed this May 27, 2017

rgw/rgw_op:Do some cleanup to prevent memory leaks when calling func …
…swift_versioning_copy() fails

Signed-off-by: jimifm <hong.zhangoole@gmail.com>

@jimifm jimifm reopened this May 27, 2017

@rzarzynski rzarzynski self-assigned this May 30, 2017

@rzarzynski

LGTM. Waiting for Teuthology results.

@rzarzynski

This comment has been minimized.

Contributor

rzarzynski commented Jun 12, 2017

The branch has been tested in following Teuthology runs:

Reference point:

The rgw multisite test failures don't seem to be related. The assertion on weak refs in OSD is well-known and appears in other, unrelated branches as well. In the log we can find:

2017-06-08T19:00:51.548 INFO:tasks.ceph.c1.osd.2.mira041.stderr:/home/jenkins-build/build/workspace/ceph-dev-new-build/ARCH/x86_64/AVAILABLE_ARCH/x86_64/AVAILABLE_DIST/centos7/DIST/centos7/MACHINE_SIZE/huge/release/12.0.2-2416-g3beddb9/rpm/el7/BUILD/ceph-12.0.2-2416-g3beddb9/src/common/shared_cache.hpp: 105: FAILED assert(weak_refs.empty())
2017-06-08T19:00:51.548 INFO:tasks.ceph.c1.osd.2.mira041.stderr:
2017-06-08T19:00:51.549 INFO:tasks.ceph.c1.osd.2.mira041.stderr: ceph version  12.0.2-2416-g3beddb9 (3beddb967cf6cbaaa6712bab86dbf3822cbe0843) luminous (dev)
2017-06-08T19:00:51.549 INFO:tasks.ceph.c1.osd.2.mira041.stderr: 1: (ceph::__ceph_assert_fail(char const*, char const*, int, char const*)+0x110) [0xafa850]
2017-06-08T19:00:51.549 INFO:tasks.ceph.c1.osd.2.mira041.stderr: 2: (()+0x5030da) [0x60b0da]
2017-06-08T19:00:51.549 INFO:tasks.ceph.c1.osd.2.mira041.stderr: 3: (OSDService::~OSDService()+0x17c) [0x594bac]
2017-06-08T19:00:51.549 INFO:tasks.ceph.c1.osd.2.mira041.stderr: 4: (OSD::~OSD()+0x133) [0x5e31a3]
2017-06-08T19:00:51.551 INFO:tasks.ceph.c1.osd.2.mira041.stderr: 5: (OSD::~OSD()+0x9) [0x5e37e9]
2017-06-08T19:00:51.551 INFO:tasks.ceph.c1.osd.2.mira041.stderr: 6: (main()+0x2f48) [0x4dc1b8]
2017-06-08T19:00:51.551 INFO:tasks.ceph.c1.osd.2.mira041.stderr: 7: (__libc_start_main()+0xf5) [0xd5bdb15]
2017-06-08T19:00:51.551 INFO:tasks.ceph.c1.osd.2.mira041.stderr: 8: (()+0x46d1d9) [0x5751d9]
2017-06-08T19:00:51.551 INFO:tasks.ceph.c1.osd.2.mira041.stderr: NOTE: a copy of the executable, or `objdump -rdS <executable>` is needed to interpret this.

@rzarzynski rzarzynski merged commit f51771b into ceph:master Jun 12, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment