New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: Add override for FsNewHandler::handle() #15331

Merged
merged 1 commit into from May 31, 2017

Conversation

Projects
None yet
2 participants
@yonghengdexin735
Contributor

yonghengdexin735 commented May 27, 2017

add override in heads
Signed-off-by: yonghengdexin735 zhang.zezhu@zte.com.cn

@joscollin

joscollin requested changes May 28, 2017 edited

Please change the Commit Title and the PR Title to "mon: Add override for FsNewHandler::handle(). This clearly conveys what change is done in the commit.

// commmands that refer to FS by name in future.
ss << "Filesystem name may not be empty";
return -EINVAL;
// Ensure fs name is not empty so that we can implement

This comment has been minimized.

@joscollin

joscollin May 28, 2017

Member

Please revert this change, as it is not related to the purpose of this PR. If you need this change create a new PR, which may include similar changes in other files too.
Please refer: https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#4-separate-your-changes

mon: Add override for FsNewHandler::handle()
Signed-off-by: yonghengdexin735 <zhang.zezhu@zte.com.cn>

@yonghengdexin735 yonghengdexin735 changed the title from mon/FSCommand:add override in heads to mon: Add override for FsNewHandler::handle() May 31, 2017

@yonghengdexin735

This comment has been minimized.

Contributor

yonghengdexin735 commented May 31, 2017

@joscollin
hi, done it, thanks.

@joscollin joscollin merged commit 13e7330 into ceph:master May 31, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment