New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: do not link libcommon against some libs #15340

Merged
merged 1 commit into from Jun 1, 2017

Conversation

Projects
None yet
3 participants
@wjwithagen
Contributor

wjwithagen commented May 28, 2017

  • This target got reintroduced by accident after the creation
    of ceph-common.
    Which was trigger by refering to libresolv, and results in a
    linking error.

Signed-off-by: Willem Jan Withagen wjw@digiware.nl

@wjwithagen wjwithagen changed the title from build: delete excidentail reintroduced line. to build: delete accidentail reintroduced line. May 28, 2017

@wjwithagen wjwithagen requested a review from tchaikov May 28, 2017

@wjwithagen wjwithagen changed the title from build: delete accidentail reintroduced line. to build: delete accidential reintroduced line. May 28, 2017

@tchaikov tchaikov changed the title from build: delete accidential reintroduced line. to cmake: do not link libcommon against some libs May 28, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented May 28, 2017

@wjwithagen could you mention that this change is included by 046b2bd by accident in your commit message? and you could also prefix this change with "cmake: "

cmake: delete excidentail reintroduced line.
- This target got reintroduced by accident after the creation
  of ceph-common in commit:
    046b2bd

  Detection was trigger by refering to libresolv, and results in a
  linking error.

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented May 29, 2017

/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/mon/misc.sh:158: jq_success:  in_escaped='
{"name":"b","rank":1,"state":"peon","election_epoch":10,"quorum":[0,1],"features":{"required_con":"153140804152475648","required_mon":["kraken","luminous"],"quorum_con":"1152323339925389307","quorum_mon":["kraken","luminous"]},"outside_quorum":[],"extra_probe_peers":["127.0.0.1:7127/0","127.0.0.1:7129/0"],"sync_provider":[],"monmap":{"epoch":3,"fsid":"163c2785-3724-4715-a323-71554b36a481","modified":"2017-05-28 18:22:57.072144","created":"2017-05-28 18:22:25.918013","features":{"persistent":["kraken","luminous"],"optional":[]},"mons":[{"rank":0,"name":"a","addr":"127.0.0.1:7127/0","public_addr":"127.0.0.1:7127/0"},{"rank":1,"name":"b","addr":"127.0.0.1:7128/0","public_addr":"127.0.0.1:7128/0"},{"rank":2,"name":"c","addr":"127.0.0.1:7129/0","public_addr":"127.0.0.1:7129/0"}]}}'
//home/jenkins-build/build/workspace/ceph-pull-requests/src/test/mon/misc.sh:159: jq_success:  printf %s '.quorum | length == 3'
//home/jenkins-build/build/workspace/ceph-pull-requests/src/test/mon/misc.sh:159: jq_success:  sed 's/'\''/'\''\\'\'''\''/g'
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/mon/misc.sh:159: jq_success:  filter_escaped='.quorum | length == 3'
//home/jenkins-build/build/workspace/ceph-pull-requests/src/test/mon/misc.sh:161: jq_success:  echo '
{"name":"b","rank":1,"state":"peon","election_epoch":10,"quorum":[0,1],"features":{"required_con":"153140804152475648","required_mon":["kraken","luminous"],"quorum_con":"1152323339925389307","quorum_mon":["kraken","luminous"]},"outside_quorum":[],"extra_probe_peers":["127.0.0.1:7127/0","127.0.0.1:7129/0"],"sync_provider":[],"monmap":{"epoch":3,"fsid":"163c2785-3724-4715-a323-71554b36a481","modified":"2017-05-28 18:22:57.072144","created":"2017-05-28 18:22:25.918013","features":{"persistent":["kraken","luminous"],"optional":[]},"mons":[{"rank":0,"name":"a","addr":"127.0.0.1:7127/0","public_addr":"127.0.0.1:7127/0"},{"rank":1,"name":"b","addr":"127.0.0.1:7128/0","public_addr":"127.0.0.1:7128/0"},{"rank":2,"name":"c","addr":"127.0.0.1:7129/0","public_addr":"127.0.0.1:7129/0"}]}}'
//home/jenkins-build/build/workspace/ceph-pull-requests/src/test/mon/misc.sh:161: jq_success:  jq '.quorum | length == 3'
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/mon/misc.sh:161: jq_success:  ret=false
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/mon/misc.sh:162: jq_success:  [[ false == \t\r\u\e ]]
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/mon/misc.sh:164: jq_success:  [[ -n "" ]]
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/mon/misc.sh:165: jq_success:  [[ false == \"\" ]]
/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/mon/misc.sh:169: jq_success:  return 1

https://jenkins.ceph.com/job/ceph-pull-requests/24900/consoleFull#-193074133240526d21-3511-427d-909c-dd086c0d1034

not likely an env issue, but neither is it relevant to this change.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented May 29, 2017

retest this please.

@tchaikov tchaikov added the needs-qa label May 29, 2017

@liewegas liewegas merged commit 268d5cd into ceph:master Jun 1, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment