Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
osd: Reverse order of op_has_sufficient_caps and do_pg_op #15354
@badone, how did you validate this works? When I skimmed through it I wasn't sure it would behave well since PG ops aren't targeted at a particular object.
@gregsfortytwo in hammer op_has_sufficient_caps was called at the top of ReplicatedPG::do_request. In 818d790 it was moved to ReplicatedPG::do_op but placed after do_pg_op for reasons I can't fathom. I validated the fix against the original reported tracker issue and also ran testing (unit and CI). I will mark this PR DNM and look into adding additional testing to check for this regression and correct auth caps validation.