Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add README to dmclock subdir to inform developers it's a git subtree #15386

Merged

Conversation

Projects
None yet
4 participants
@ivancich
Copy link
Member

ivancich commented May 31, 2017

Since dmclock was integrated into ceph a short time ago, twice now
contributors have submitted PRs to modify files below src/dmclock when
they should have modified the external dmclock library itself. This
README file is designed to hopefully warn future contributors and
instruct them on how best to approach changes.

doc: add README to dmclock subdir to inform developers it's a git sub…
…tree

Since dmclock was integrated into ceph a short time ago, twice now
contributors have submitted PRs to modify files below src/dmclock when
they should have modified the external dmclock library itself. This
README file is designed to hopefully warn future contributors and
instruct them on how best to approach changes.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

@ivancich ivancich requested a review from jdurgin May 31, 2017

@jdurgin

jdurgin approved these changes Jun 6, 2017

@jdurgin jdurgin merged commit bc8c432 into ceph:master Jun 6, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Jul 26, 2017

@Chenshihao2 i'd suggest you post this question to ceph-user mailing list and copy it to ceph-devel.

@Chenshihao2

This comment has been minimized.

Copy link

Chenshihao2 commented Jul 26, 2017

@tchaikov OK.Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.