Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install-deps.sh: workaround setuptools' dependency on six #15406

Merged
merged 1 commit into from Jun 1, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Copy link
Contributor

tchaikov commented Jun 1, 2017

No description provided.

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

tchaikov commented Jun 1, 2017

see #15404

@tchaikov tchaikov force-pushed the tchaikov:wip-setuptools-vendors-six-or-not branch from 10fd03a to 41cfa1f Jun 1, 2017

@badone

badone approved these changes Jun 1, 2017

Copy link
Contributor

badone left a comment

LGTM. Feel free to close #15404 if this builds successfully.

@tchaikov tchaikov force-pushed the tchaikov:wip-setuptools-vendors-six-or-not branch from 41cfa1f to b40287b Jun 1, 2017

@tchaikov tchaikov changed the title Wip setuptools vendors six or not tools/install-deps.sh: install setuptools < 36 to workaround the six dependency Jun 1, 2017

@tchaikov tchaikov force-pushed the tchaikov:wip-setuptools-vendors-six-or-not branch from b40287b to 27b5105 Jun 1, 2017

@tchaikov tchaikov changed the title tools/install-deps.sh: install setuptools < 36 to workaround the six dependency install-deps.sh: workaround setuptools' dependency on six Jun 1, 2017

@badone

badone approved these changes Jun 1, 2017

Copy link
Contributor

badone left a comment

LGTM

install-deps.sh: workaround setuptools' dependency on six
see also pypa/setuptools#1042

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov force-pushed the tchaikov:wip-setuptools-vendors-six-or-not branch from 27b5105 to 30ce5e5 Jun 1, 2017

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

tchaikov commented Jun 1, 2017

Successfully installed ceph-disk
[ 22%] Built target ceph-disk
...
Successfully installed ceph-detect-init
[ 22%] Built target ceph-detect-init

@tchaikov tchaikov merged commit f7edefb into ceph:master Jun 1, 2017

2 of 3 checks passed

default Build started sha1 is merged.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details

@tchaikov tchaikov deleted the tchaikov:wip-setuptools-vendors-six-or-not branch Jun 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.