New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds/MDBalancer: remove useless check_targets and hit_targets logic from MDS balancer #15407

Merged
merged 1 commit into from Jun 15, 2017

Conversation

Projects
None yet
4 participants
@david-z
Member

david-z commented Jun 1, 2017

Currently Multiple MDSes fail to do rebalance because MDS's export_targets in MDSMap are empty even if they need to do rebalance.

The reason is that we didn't update MDSRank's export_targets according to balance state, then MDSRank's tick won't update MDSMap's export_targets to Mon. And the new function MDBalancer::hit_targets should be aimed to do such things, but it hadn't been called at anywhere.

Fixes: #http://tracker.ceph.com/issues/20131

Signed-off-by: Zhi Zhang zhangz.david@outlook.com

@david-z david-z requested a review from batrick Jun 1, 2017

@david-z

This comment has been minimized.

Member

david-z commented Jun 1, 2017

Build failures are not related to this change.

@batrick

Actually, MDBalancer::check_targets and MDBalancer::hit_targets were mistakenly left in after the change to have the Migrator check and hit export targets before performing migration. The MDBalancer should not need to handle this anymore. Can you go ahead and remove all of that logic from the balancer.

Zhi Zhang
mds/MDBalancer: remove useless check_targets and hit_targets logic fr…
…om MDS balancer

Currently the logic that check and hit export targets has been moved to Migrator. So remove the check_targets and hit_targets logic still remaining in MDS balancer which causes MDS failing to do rebalance.

Signed-off-by: Zhi Zhang <zhangz.david@outlook.com>

@david-z david-z changed the title from mds/MDBalancer: update MDSRank export_targets according to current balance state to mds/MDBalancer: remove useless check_targets and hit_targets logic from MDS balancer Jun 2, 2017

@david-z

This comment has been minimized.

Member

david-z commented Jun 2, 2017

@batrick You are right. I removed those useless logic from MDS balancer and let Migrator to do such things only. Now rebalance can work when needed.

@batrick

batrick approved these changes Jun 2, 2017

Great, thanks!

@batrick

This comment has been minimized.

Member

batrick commented Jun 2, 2017

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

@liewegas liewegas added the cephfs label Jun 2, 2017

@jcsp jcsp merged commit 0f2130e into ceph:master Jun 15, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment