New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-disk: do not setup_statedir on trigger #15410

Merged
1 commit merged into from Jun 1, 2017

Conversation

Projects
None yet
3 participants
@ghost

ghost commented Jun 1, 2017

trigger may run when statedir is unavailable and does not use it.

Fixes: http://tracker.ceph.com/issues/19941

Signed-off-by: Loic Dachary loic@dachary.org

ceph-disk: do not setup_statedir on trigger
trigger may run when statedir is unavailable and does not use it.

Fixes: http://tracker.ceph.com/issues/19941

Signed-off-by: Loic Dachary <loic@dachary.org>

@ghost ghost added bug fix core labels Jun 1, 2017

@ghost

This comment has been minimized.

ghost commented Jun 1, 2017

@ddiss does this look right to you ? (as an alternative implementation for #15241)

@ghost

This comment has been minimized.

ghost commented Jun 1, 2017

pushed to ceph-ci

@ddiss

This comment has been minimized.

Contributor

ddiss commented Jun 1, 2017

Yes, it looks okay to me. My preference would still be to bypass "ceph-disk trigger" completely via a new systemd specific udev rule, but I won't object to this change.

@ghost

This comment has been minimized.

ghost commented Jun 1, 2017

@ddiss thanks for the quick reply. Changing the code path is a larger change and keeping this fix minimal will greatly help with the required backports.

@ghost ghost requested a review from tchaikov Jun 1, 2017

@ghost

This comment has been minimized.

ghost commented Jun 1, 2017

teuthology-suite -k distro --verbose --suite ceph-disk --ceph wip-19941-ceph-disk  --machine-type vps
@ghost

This comment has been minimized.

ghost commented Jun 1, 2017

jenkins retest this please

@ghost ghost requested a review from ddiss Jun 1, 2017

@ddiss

ddiss approved these changes Jun 1, 2017

@ghost

This comment has been minimized.

ghost commented Jun 1, 2017

@ddiss would you mind adding a "Review" ? That will allow me to merge the change :-)

@ghost ghost merged commit 9c4aa77 into ceph:master Jun 1, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment