Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build/ops: Fix cmake build error. #15425

Merged
merged 1 commit into from Jun 2, 2017

Conversation

Projects
None yet
3 participants
@yaozongyou
Copy link
Contributor

yaozongyou commented Jun 2, 2017

Signed-off-by: Yao Zongyou yaozongyou@vip.qq.com

Fix cmake build error.
Signed-off-by: Yao Zongyou <yaozongyou@vip.qq.com>

@yaozongyou yaozongyou changed the title Fix cmake build error. build/ops: Fix cmake build error. Jun 2, 2017

@yaozongyou

This comment has been minimized.

Copy link
Contributor Author

yaozongyou commented Jun 2, 2017

In build directory, when running CMake .., the following error is got:

CMake Error at src/rgw/CMakeLists.txt:243 (target_include_directories):
target_include_directories called with incorrect number of arguments

WITH_RADOSGW_FCGI_FRONTEND is off by default, so this flag should be checked here.

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Jun 2, 2017

@yaozongyou i think we are planning to remove fcgi support completely

@cbodley if we are going to remove fcgi support, we can just drop these lines as part of that change?

@cbodley

This comment has been minimized.

Copy link
Contributor

cbodley commented Jun 2, 2017

@tchaikov i don't know how soon we'll get around to it - i think this pr is good for now

@tchaikov tchaikov merged commit d5f178f into ceph:master Jun 2, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov added the build/ops label Jun 2, 2017

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Jun 2, 2017

@cbodley gotcha!

@yaozongyou yaozongyou deleted the yaozongyou:fix-build-error branch Jun 3, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.