New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: fix warning #15435

Merged
merged 1 commit into from Jun 7, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented Jun 2, 2017

The following warning appears during make:

ceph/src/os/bluestore/BlueStore.cc: In member function ‘void BlueStore::_txc_finish(BlueStore::TransContext*)’:
ceph/src/os/bluestore/BlueStore.cc:7823:20: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
      osr->q.size() > g_conf->bluestore_max_deferred_txc) {
      ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Sage Weil sage@redhat.com

@joscollin

The fix looks good to me. Could you please specify the warning in the PR and commit message ?

I hope it is "warning: comparison between signed and unsigned integer expressions [-Wsign-compare]"

os/bluestore: fix warning
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas merged commit f477191 into ceph:master Jun 7, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@liewegas liewegas deleted the liewegas:wip-bluestore-warning branch Jun 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment