New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: rgw: multisite: rest api fails to decode large period on "period commit" #15447

Merged
merged 1 commit into from Aug 22, 2017

Conversation

Projects
None yet
2 participants
@smithfarm
Contributor

smithfarm commented Jun 3, 2017

@smithfarm smithfarm self-assigned this Jun 3, 2017

@smithfarm smithfarm added this to the jewel milestone Jun 3, 2017

@smithfarm smithfarm added bug fix core rgw and removed core labels Jun 3, 2017

@smithfarm smithfarm changed the title from jewel: multisite: rest api fails to decode large period on 'period commit' to jewel: rgw: multisite: rest api fails to decode large period on 'period commit' Jun 3, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Jun 4, 2017

Contributor
rgw/rgw_rest_realm.cc: In member function ‘virtual void RGWOp_Period_Post::execute()’:
rgw/rgw_rest_realm.cc:87:37: error: ‘struct md_config_t’ has no member named ‘rgw_max_put_param_size’
   const auto max_size = cct->_conf->rgw_max_put_param_size;
                                     ^
Makefile:24840: recipe for target 'rgw/librgw_la-rgw_rest_realm.lo' failed
Contributor

smithfarm commented Jun 4, 2017

rgw/rgw_rest_realm.cc: In member function ‘virtual void RGWOp_Period_Post::execute()’:
rgw/rgw_rest_realm.cc:87:37: error: ‘struct md_config_t’ has no member named ‘rgw_max_put_param_size’
   const auto max_size = cct->_conf->rgw_max_put_param_size;
                                     ^
Makefile:24840: recipe for target 'rgw/librgw_la-rgw_rest_realm.lo' failed

@smithfarm smithfarm changed the title from jewel: rgw: multisite: rest api fails to decode large period on 'period commit' to [DNM] jewel: rgw: multisite: rest api fails to decode large period on 'period commit' Jun 4, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Jun 4, 2017

Contributor

This backport depends on 35375b7 - marking DNM until we determine whether to backport that more complicated commit.

Contributor

smithfarm commented Jun 4, 2017

This backport depends on 35375b7 - marking DNM until we determine whether to backport that more complicated commit.

@smithfarm smithfarm requested a review from cbodley Jul 12, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Jul 12, 2017

Contributor

Jenkins re-test this please

@cbodley What's your take on this backporting dilemma?

Contributor

smithfarm commented Jul 12, 2017

Jenkins re-test this please

@cbodley What's your take on this backporting dilemma?

rgw: allow larger payload for period commit
testing with 3 zonegroups and 3 zones each, the period json grew larger
than 4k and caused decode failures on period commit

updated to use the new config variable rgw_max_put_param_size

Fixes: http://tracker.ceph.com/issues/19505

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 7f2871f)

Conflicts:
    src/rgw/rgw_rest_realm.cc - in RGWOp_Period_Post::execute(), set max_size
        explicitly instead of backporting rgw_max_put_param_size

@smithfarm smithfarm changed the title from [DNM] jewel: rgw: multisite: rest api fails to decode large period on 'period commit' to jewel: rgw: multisite: rest api fails to decode large period on 'period commit' Jul 12, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Jul 12, 2017

Contributor

@cbodley Done, thanks.

Contributor

smithfarm commented Jul 12, 2017

@cbodley Done, thanks.

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Aug 22, 2017

Contributor

This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-8

Contributor

smithfarm commented Aug 22, 2017

This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-8

@smithfarm smithfarm merged commit 161cba9 into ceph:jewel Aug 22, 2017

3 of 4 checks passed

Docs: build check Docs: building
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-19613-jewel branch Aug 22, 2017

@smithfarm smithfarm changed the title from jewel: rgw: multisite: rest api fails to decode large period on 'period commit' to jewel: rgw: multisite: rest api fails to decode large period on "period commit" Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment