New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: rgw: multisite: bucket zonegroup redirect not working #15448

Merged
merged 2 commits into from Aug 22, 2017

Conversation

Projects
None yet
3 participants
@smithfarm
Contributor

smithfarm commented Jun 3, 2017

@smithfarm smithfarm self-assigned this Jun 3, 2017

@smithfarm smithfarm added this to the jewel milestone Jun 3, 2017

@smithfarm smithfarm changed the title from jewel: multisite: bucket zonegroup redirect not working to jewel: rgw: multisite: bucket zonegroup redirect not working Jun 3, 2017

@smithfarm smithfarm added rgw and removed core labels Jun 3, 2017

cbodley added some commits Apr 4, 2017

rgw: use zonegroup's master zone endpoints for bucket redirect
if no zonegroup endpoints are set, fall back to master zone endpoints

Fixes: http://tracker.ceph.com/issues/19488

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 92f63c6)
rgw: fix for zonegroup redirect url
local dest_url variable was shadowing the one in the enclosing scope, so
the changes were not applied and no Location header was written on redirect

Fixes: http://tracker.ceph.com/issues/19488

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 542e188)
@@ -369,6 +369,12 @@ int rgw_build_bucket_policies(RGWRados* store, struct req_state* s)
if (!r) {
if (!zonegroup.endpoints.empty()) {
s->zonegroup_endpoint = zonegroup.endpoints.front();
} else {
// use zonegroup's master zone endpoints

This comment has been minimized.

@amitkumar50

amitkumar50 Aug 16, 2017

Contributor

@smithfarm I believe It would be even better if we start comment with capital letter.

@amitkumar50

amitkumar50 Aug 16, 2017

Contributor

@smithfarm I believe It would be even better if we start comment with capital letter.

This comment has been minimized.

@smithfarm

smithfarm Aug 16, 2017

Contributor

@amitkumar50 Please check that the PR is targeting master before suggesting any changes.

@smithfarm

smithfarm Aug 16, 2017

Contributor

@amitkumar50 Please check that the PR is targeting master before suggesting any changes.

@smithfarm smithfarm requested review from yehudasa and cbodley Aug 22, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Aug 22, 2017

Contributor

@yehudasa @cbodley This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-8

Please review.

Contributor

smithfarm commented Aug 22, 2017

@yehudasa @cbodley This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-8

Please review.

@smithfarm smithfarm merged commit 198f7fa into ceph:jewel Aug 22, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-19615-jewel branch Aug 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment