jewel: rgw: multisite: realm rename does not propagate to other clusters #15454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithfarm
changed the title
|
Jenkins re-test this please (unittest_throttle) |
Fixes: http://tracker.ceph.com/issues/19746 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit 8a459c7)
smithfarm
force-pushed
the
wip-19775-jewel
branch
from
8f07d4c
to
01890ab
Compare
amitkumar50
suggested changes
Aug 16, 2017
| @@ -2993,6 +2993,9 @@ int main(int argc, char **argv) | |||
| cerr << "realm.rename failed: " << cpp_strerror(-ret) << std::endl; | |||
| return -ret; | |||
| } | |||
| cout << "Realm name updated. Note that this change only applies to " | |||
| "the current cluster, so this command must be run separately " | |||
There was a problem hiding this comment.
@smithfarm I believe this is incorrect sentence"so this command must be run separately" should be something as:
"so this command must run separately"
There was a problem hiding this comment.
@amitkumar50 Backports are cherry-picked from master, so any changes would have to go into master, first.
("this command must be run separately" is fine as it is, though)
|
@oritwas This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-18 Please review. |
oritwas
approved these changes
Aug 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/19775