New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: rgw: multisite: realm rename does not propagate to other clusters #15454

Merged
merged 1 commit into from Aug 25, 2017

Conversation

Projects
None yet
4 participants
@smithfarm
Contributor

smithfarm commented Jun 3, 2017

@smithfarm smithfarm self-assigned this Jun 3, 2017

@smithfarm smithfarm added this to the jewel milestone Jun 3, 2017

@smithfarm smithfarm added bug fix core rgw and removed core labels Jun 3, 2017

@smithfarm smithfarm changed the title from jewel: multisite: realm rename does not propagate to other clusters to jewel: rgw: multisite: realm rename does not propagate to other clusters Jun 3, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Jun 5, 2017

Contributor

Jenkins re-test this please (unittest_throttle)

Contributor

smithfarm commented Jun 5, 2017

Jenkins re-test this please (unittest_throttle)

radosgw-admin: warn that 'realm rename' does not update other clusters
Fixes: http://tracker.ceph.com/issues/19746

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 8a459c7)
@@ -2993,6 +2993,9 @@ int main(int argc, char **argv)
cerr << "realm.rename failed: " << cpp_strerror(-ret) << std::endl;
return -ret;
}
cout << "Realm name updated. Note that this change only applies to "
"the current cluster, so this command must be run separately "

This comment has been minimized.

@amitkumar50

amitkumar50 Aug 16, 2017

Contributor

@smithfarm I believe this is incorrect sentence"so this command must be run separately" should be something as:
"so this command must run separately"

@amitkumar50

amitkumar50 Aug 16, 2017

Contributor

@smithfarm I believe this is incorrect sentence"so this command must be run separately" should be something as:
"so this command must run separately"

This comment has been minimized.

@smithfarm

smithfarm Aug 16, 2017

Contributor

@amitkumar50 Backports are cherry-picked from master, so any changes would have to go into master, first.

("this command must be run separately" is fine as it is, though)

@smithfarm

smithfarm Aug 16, 2017

Contributor

@amitkumar50 Backports are cherry-picked from master, so any changes would have to go into master, first.

("this command must be run separately" is fine as it is, though)

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Aug 25, 2017

Contributor

@oritwas This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-18

Please review.

Contributor

smithfarm commented Aug 25, 2017

@oritwas This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-18

Please review.

@smithfarm smithfarm requested a review from oritwas Aug 25, 2017

@smithfarm smithfarm merged commit 47e3ff8 into ceph:jewel Aug 25, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-19775-jewel branch Aug 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment