New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: rgw: rgw_file: cannot delete bucket w/uxattrs #15459

Merged
merged 4 commits into from Aug 26, 2017

Conversation

Projects
None yet
2 participants

@smithfarm smithfarm self-assigned this Jun 4, 2017

@smithfarm smithfarm added this to the jewel milestone Jun 4, 2017

@smithfarm smithfarm requested a review from mattbenjamin Jun 4, 2017

@smithfarm smithfarm added rgw and removed core labels Jun 4, 2017

@mattbenjamin

lgtm

mattbenjamin added some commits Mar 7, 2017

rgw_file: fix fs_inst progression
Reported by Gui Hecheng<guimark@126.com>.  This change is a
variation on proposed fix by Dan Gryniewicz<dang@redhat.com>
to take root_fh.state.dev as fs_inst for new handles.

Fixes: http://tracker.ceph.com/issues/19214

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit 0e988ed)
rgw_file: remove hidden uxattr objects from buckets on delete
If a setattr (e.g., chown) has been performed on a bucket, then like
any directory it has a hidden object storing its attributes. This must
be deleted before attempting bucket delete, otherwise, actually empty
buckets will not be removable via NFS.

Fixes: http://tracker.ceph.com/issues/20045

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit 01e15c3)

Conflicts:
        src/rgw/rgw_file.cc (jewel does not have
                "inline int valid_fs_bucket_name()" and
                "inline int valid_fs_object_name()")
rgw_file: remove post-unlink lookup check
This could induce asserts in multi-nfs-gateway scenarios.

Fixes: http://tracker.ceph.com/issues/20047

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit b3db617)
rgw_file: release rgw_fh lock and ref on ENOTEMPTY
An early return in new unlink bucket num_entries check was
missing a conditional unlock and unref.

Fixes: http://tracker.ceph.com/issues/20061

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit 51c2559)

@smithfarm smithfarm changed the title from jewel: rgw_file: cannot delete bucket w/uxattrs to jewel: rgw: rgw_file: cannot delete bucket w/uxattrs Jul 12, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Aug 25, 2017

Contributor

This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-18 and @mattbenjamin has already approved it, so I'll merge unless there are objections.

Contributor

smithfarm commented Aug 25, 2017

This passed an rgw suite at http://tracker.ceph.com/issues/20613#note-18 and @mattbenjamin has already approved it, so I'll merge unless there are objections.

@smithfarm smithfarm merged commit 9302a44 into ceph:jewel Aug 26, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-20144-jewel branch Aug 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment