New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: revert -Wvla from #15342 #15469

Merged
merged 1 commit into from Jun 5, 2017

Conversation

Projects
None yet
3 participants
@wjwithagen
Contributor

wjwithagen commented Jun 4, 2017

  • VLAs are in GCC and Clang, and are there to stay forever,
    if only to be compatible with all the software that is already
    out there.
    • Theoretical debates about VLA being hard to implement are
      long superceded by th actual implentations
  • Before setting this flag is would be required to first start
    work on fixing all the fallout/warnings that will arise from
    setting -Wvla
  • Allocating large variable/stuctures on the stack could be asking
    for trouble, but changes that ceph tools are going to be running
    on small embedded devices are rather slim.

Signed-off-by: Willem Jan Withagen wjw@digiware.nl

build: revert -Wvla from #15342
 - VLAs are in GCC and Clang, and are there to stay forever,
   if only to be compatible with all the software that is already
   out there.
   - Theoretical debates about VLA being hard to implement are
     long superceded by th actual implentations
 - Before setting this flag is would be required to first start
   work on fixing all the fallout/warnings that will arise from
   setting -Wvla
 - Allocating large variable/stuctures on the stack could be asking
   for trouble, but changes that ceph tools are going to be running
   on small embedded devices are rather slim.

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>

@wjwithagen wjwithagen requested a review from tchaikov Jun 4, 2017

@wjwithagen wjwithagen added the build/ops label Jun 4, 2017

@liewegas liewegas added the needs-qa label Jun 5, 2017

@liewegas liewegas merged commit 765b9d2 into ceph:master Jun 5, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment