New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libradosstriper: fix MultiAioCompletion leaks on failure #15471

Merged
merged 2 commits into from Jun 29, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Contributor

tchaikov commented Jun 5, 2017

No description provided.

tchaikov added some commits Jun 5, 2017

radosstriper: use intrusive_ptr to manage lifecycle of MultiAioComple…
…tionImpl

this change also silence some cppcheck warnings: we fail to rlease
references to MultiAioCompletionImpl in some of the error handling paths.

Signed-off-by: Kefu Chai <kchai@redhat.com>
radosstriper: assert(ref==1) in MultiAioCompletion's dtor
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jun 20, 2017

retest this please.

@tchaikov tchaikov requested a review from liewegas Jun 20, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jun 20, 2017

@liewegas could you help take a look?

@tchaikov tchaikov requested a review from jdurgin Jun 25, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jun 25, 2017

@jdurgin do you mind taking a look?

@tchaikov tchaikov merged commit 7a9ca4e into ceph:master Jun 29, 2017

5 of 6 checks passed

arm64 make check arm64 make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
Unmodified Submodules submodules for project are unmodified
Details
default Build finished.
Details
make check make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-radostriper-leak-on-fail branch Jun 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment