New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/perf_counters: add average time for PERFCOUNTER_TIME #15478

Merged
merged 1 commit into from Jun 5, 2017

Conversation

Projects
None yet
3 participants
@xiexingguo
Member

xiexingguo commented Jun 5, 2017

Otherwise we'll have to calculate this manually, which is annoying.

Demo:

       "op_rw_prepare_latency": {
            "avgcount": 53,
            "sum": 0.097761740,
            "avgtime": 0.001844561
        },
        "subop": 209,
        "subop_in_bytes": 100423461,
        "subop_latency": {
            "avgcount": 209,
            "sum": 414.623068367,
            "avgtime": 1.983842432
        },
        "subop_w": 209,
        "subop_w_in_bytes": 100423461,
        "subop_w_latency": {
            "avgcount": 209,
            "sum": 414.623068367,
            "avgtime": 1.983842432
        },

Signed-off-by: xie xingguo xie.xingguo@zte.com.cn

common/perf_counters: add average time for PERFCOUNTER_TIME
Otherwise we'll have to calculate this manually, which is annoying.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@liewegas

This comment has been minimized.

Member

liewegas commented Jun 5, 2017

This is fine for what it is, although in practice anything monitoring this should be looking at the delta for sum and count between samples to get an average for that specific time period; the lifetime average isn't super useful.

@liewegas liewegas merged commit ac7c2c1 into ceph:master Jun 5, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@xiexingguo xiexingguo deleted the xiexingguo:wip-perf-avg-time branch Jun 6, 2017

@liupan1111

This comment has been minimized.

Contributor

liupan1111 commented Jul 17, 2017

not understand what is the difference with my pr before:
#12199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment