New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: rbd: rbd-mirror: ensure missing images are re-synced when detected #15488

Merged
merged 1 commit into from Aug 28, 2017

Conversation

Projects
None yet
3 participants
@dillaman
Contributor

dillaman commented Jun 5, 2017

rbd-mirror: ensure missing images are re-synced when detected
Fixes: http://tracker.ceph.com/issues/19811
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 74bd4f2)

Conflicts:
	src/test/rbd_mirror/image_replayer/test_mock_BootstrapRequest.cc: trivial resolution
	src/tools/rbd_mirror/image_replayer/BootstrapRequest.h: trivial resolution

@dillaman dillaman added this to the jewel milestone Jun 5, 2017

@trociny

trociny approved these changes Jun 6, 2017

LGTM

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Jun 19, 2017

Contributor

@dillaman Please rebase.

Contributor

smithfarm commented Jun 19, 2017

@dillaman Please rebase.

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Jun 19, 2017

Contributor

Jenkins re-test this please

(maybe rebasing is not necessary)

Contributor

smithfarm commented Jun 19, 2017

Jenkins re-test this please

(maybe rebasing is not necessary)

@smithfarm smithfarm changed the title from jewel: rbd-mirror: ensure missing images are re-synced when detected to jewel: rbd: rbd-mirror: ensure missing images are re-synced when detected Jul 12, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Aug 28, 2017

Contributor

@dillaman This passed an rbd suite at http://tracker.ceph.com/issues/20613#note-31 (there was 1 failure that passed on rerun).

The rados run is putting up a bit of a fight; there are a couple failures but they don't appear to be reliably reproducible or related to rbd: http://tracker.ceph.com/issues/20613#note-25

I also ran three different upgrade suites and all the failures were either not reproducible or were "hand-waved away".

OK to merge?

Contributor

smithfarm commented Aug 28, 2017

@dillaman This passed an rbd suite at http://tracker.ceph.com/issues/20613#note-31 (there was 1 failure that passed on rerun).

The rados run is putting up a bit of a fight; there are a couple failures but they don't appear to be reliably reproducible or related to rbd: http://tracker.ceph.com/issues/20613#note-25

I also ran three different upgrade suites and all the failures were either not reproducible or were "hand-waved away".

OK to merge?

@dillaman

lgtm (cannot approve)

@smithfarm smithfarm merged commit 988559b into ceph:jewel Aug 28, 2017

6 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
Unmodified Submodules submodules for project are unmodified
Details
default Build finished.
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment