New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: include/types.h, introduce host_to_ceph_errno #15496

Merged
merged 1 commit into from Jun 6, 2017

Conversation

Projects
None yet
3 participants
@wjwithagen
Contributor

wjwithagen commented Jun 5, 2017

  • As preparation for interconnecting ceph_daemons on
    different platfoms

Signed-off-by: Willem Jan Withagen wjw@digiware.nl

core: include/types.h, introduce host_to_ceph_errno
 - As preparation for interconnecting ceph_daemons on
   different platfoms

Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>

@liewegas liewegas added the needs-qa label Jun 5, 2017

@@ -476,8 +476,10 @@ ostream &operator<<(ostream &lhs, const shard_id_t &rhs);
#if defined(__sun) || defined(_AIX) || defined(DARWIN)
__s32 ceph_to_host_errno(__s32 e);
__s32 host_to_ceph_errno(__s32 e);

This comment has been minimized.

@tchaikov

tchaikov Jun 6, 2017

Contributor

@wjwithagen but where is it defined? in other words, this breaks the build on these platforms (if they are not broken already...)

This comment has been minimized.

@wjwithagen

wjwithagen Jun 6, 2017

Contributor

@tchaikov
I submitted this part separate on request from Sage.
I'm adding the other stuff to my original PR #15495.
Note, like you suggest, that the code to compile SUN|AIX|DARWIN eerno.cc is not in Cmake ATM.

@tchaikov

i c. lgtm then.

@liewegas liewegas merged commit 6144213 into ceph:master Jun 6, 2017

1 of 3 checks passed

Signed-off-by checking if commits are signed
Details
Unmodifed Submodules Build triggered. sha1 is merged.
Details
default Build finished.
Details

@wjwithagen wjwithagen deleted the wjwithagen:wip-wjw-host-to-ceph-errno branch Jun 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment