Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
mon/PGMap: call blocked requests ERR not WARN #15501
I'm concerned that it's pretty common to get slow requests during peering and recovery processes on overloaded clusters. This is going to significantly turn up the amount of "errors" sys admins see and have to react to. Could we at least only make it an error when they stick around for a threshold higher than the one where we mark them slow?
As discussed verbally, we want to wait a loooong time before promoting blocked ops to an error since they're very likely to be caused by general slowness or else other cluster state issues.
The commit message now incorrectly refers to 2x, but otherwise:
Reviewed-by: Greg Farnum firstname.lastname@example.org