New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: tools: ceph-disk: separate ceph-osd --check-needs-* logs #15503

Merged
merged 1 commit into from Aug 28, 2017

Conversation

Projects
None yet
3 participants
@Vicente-Cheng
Contributor

Vicente-Cheng commented Jun 6, 2017

@smithfarm smithfarm added this to the jewel milestone Jun 6, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Jun 19, 2017

Contributor

@Vicente-Cheng Please rebase.

Contributor

smithfarm commented Jun 19, 2017

@Vicente-Cheng Please rebase.

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Jun 19, 2017

Contributor

Jenkins re-test this please

Contributor

smithfarm commented Jun 19, 2017

Jenkins re-test this please

ceph-disk: separate ceph-osd --check-needs-* logs
It is using the OSD id zero but have nothing to do with OSD zero and
this is confusing to the user. The log themselves do not need to be kept
around and are stored in the run directory so that they can be disposed
of after reboot.

Fixes: http://tracker.ceph.com/issues/19888

Signed-off-by: Loic Dachary <loic@dachary.org>
(cherry picked from commit c7b3c46)
@Vicente-Cheng

This comment has been minimized.

Show comment
Hide comment
@Vicente-Cheng

Vicente-Cheng Jun 20, 2017

Contributor

@smithfarm rebase done!

Contributor

Vicente-Cheng commented Jun 20, 2017

@smithfarm rebase done!

@Vicente-Cheng

This comment has been minimized.

Show comment
Hide comment
@Vicente-Cheng

Vicente-Cheng Jun 20, 2017

Contributor

retest this please

Contributor

Vicente-Cheng commented Jun 20, 2017

retest this please

@smithfarm smithfarm changed the title from jewel: ceph-disk: separate ceph-osd --check-needs-* logs to jewel: tools: ceph-disk: separate ceph-osd --check-needs-* logs Jul 12, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Aug 28, 2017

Contributor

This passed a ceph-disk suite at http://tracker.ceph.com/issues/20613#note-30

Contributor

smithfarm commented Aug 28, 2017

This passed a ceph-disk suite at http://tracker.ceph.com/issues/20613#note-30

@smithfarm smithfarm merged commit 14a5286 into ceph:jewel Aug 28, 2017

3 of 4 checks passed

Docs: build check Docs: building
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@Vicente-Cheng Vicente-Cheng deleted the Vicente-Cheng:wip-20011-jewel branch Aug 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment