New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crc32c: include acconfig.h to fix ceph_crc32c_aarch64() #15515

Merged
merged 1 commit into from Jun 6, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Contributor

tchaikov commented Jun 6, 2017

it's a regresssion introduced by 2a3382f

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov tchaikov requested a review from dmick Jun 6, 2017

@dmick

This comment has been minimized.

Member

dmick commented Jun 6, 2017

Could we add a sentence of explanation?

crc32c: include acconfig.h to fix ceph_crc32c_aarch64()
HAVE_ARMV8_CRC is defined by "acconfig.h". so we need to include it for
the definition.

it's a regresssion introduced by 2a3382f. in that change,
crc32c_intel_baseline.h was removed from crc32.cc, and that header
includes accconfig.h indirectly. that's why we will have a dummy
ceph_crc32c_aarch64() which always returns 0. the dummy implementation
was intended to please the compiler. but we can probably just drop it in
future as a cleanup.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jun 6, 2017

@dmick updated and repushed.

@dmick

This comment has been minimized.

Member

dmick commented Jun 6, 2017

Thanks, makes perfect sense except for why we're still using a file named after autoconfig. O_o but there you go.

@dmick

dmick approved these changes Jun 6, 2017

Seems to have fixed all the errors. Thanks for the quick diagnosis; it would have taken me a lot longer.

@dmick dmick merged commit 845fc3e into ceph:master Jun 6, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-crc32-aarch64 branch Jun 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment