New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph_test_rados_api_misc: fix LibRadosMiscConnectFailure.ConnectFailure retry #15522

Merged
merged 1 commit into from Jun 7, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Member

liewegas commented Jun 6, 2017

Fixes: http://tracker.ceph.com/issues/19901
Signed-off-by: Sage Weil sage@redhat.com

@liewegas liewegas requested a review from tchaikov Jun 7, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Jun 7, 2017

ready to merge after review

@@ -78,6 +78,7 @@ TEST(LibRadosMiscConnectFailure, ConnectFailure) {
break; // yay, we timed out
// try again
rados_shutdown(cluster);
ASSERT_EQ(0, rados_create(&cluster, NULL));

This comment has been minimized.

@tchaikov

tchaikov Jun 7, 2017

Contributor

right. rados_shutdown() will destroy the underlying RadosClient, and leave us an invalid pointer.

@tchaikov tchaikov merged commit 8904af1 into ceph:master Jun 7, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment