New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: rename osd -> osd_pglog; include pglog-related bufferlists #15531

merged 4 commits into from Jun 7, 2017


None yet
3 participants

liewegas commented Jun 7, 2017

This captures the snaps bufferlist and the ObjectModDesc (which has the
rollback metadata and can be quite large for EC pools).


jdurgin approved these changes Jun 7, 2017

while (!entries.empty()) {
mempool::osd::list<pg_log_entry_t> &out_list = (*out_entries)[entries.front().soid];
mempool::osd_pglog::list<pg_log_entry_t> &out_list = (*out_entries)[entries.front().soid];

This comment has been minimized.


tchaikov Jun 7, 2017


could also put

auto &out_list = (*out_entries)[entries.front().soid];

liewegas added some commits Jun 6, 2017

osd: move pglog to osd_pglog mempool
This actually everything in the osd mempool, so it's basically a rename.

Signed-off-by: Sage Weil <>
osd: map ObjectModDesc to osd_pglog pool
This can consume significant space for EC pools.

Signed-off-by: Sage Weil <>
osd: put pg_log_entry_t::snaps in osd_pglog mempool
Signed-off-by: Sage Weil <>
osd/osd_types: put pg_log_entry_t::extra_reqids in osd_pglog mempool
Signed-off-by: Sage Weil <>

@liewegas liewegas merged commit 99332b9 into ceph:master Jun 7, 2017

1 of 3 checks passed

Unmodifed Submodules checking if PR has modified submodules
default Build started sha1 is merged.
Signed-off-by all commits in this PR are signed

@liewegas liewegas deleted the liewegas:wip-osd-pglog branch Jun 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment