New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/osd: Removed Commented Code - 2 #15540

Merged
merged 1 commit into from Jun 20, 2017

Conversation

Projects
None yet
3 participants
@joscollin
Member

joscollin commented Jun 7, 2017

Removed commented code found while reviewing another PR.

Fixes: http://tracker.ceph.com/issues/20207 (Partially)

Signed-off-by: Jos Collin jcollin@redhat.com

@joscollin

This comment has been minimized.

Member

joscollin commented Jun 13, 2017

Jenkins Retest this please

@joscollin joscollin requested a review from liewegas Jun 20, 2017

@@ -703,7 +703,6 @@ TEST(pg_missing_t, claim)
TEST(pg_missing_t, is_missing)
{
// pg_missing_t::is_missing(const hobject_t& oid) const

This comment has been minimized.

@liewegas

liewegas Jun 20, 2017

Member

this is a real comment, not commented-out code

@@ -712,7 +711,6 @@ TEST(pg_missing_t, is_missing)
EXPECT_TRUE(missing.is_missing(oid));
}
// bool pg_missing_t::is_missing(const hobject_t& oid, eversion_t v) const

This comment has been minimized.

@liewegas
@@ -970,7 +968,7 @@ TEST(pg_missing_t, add)
TEST(pg_missing_t, rm)
{
// void pg_missing_t::rm(const hobject_t& oid, eversion_t v)

This comment has been minimized.

@liewegas
@joscollin

This comment has been minimized.

Member

joscollin commented Jun 20, 2017

@liewegas Done.

@liewegas

This comment has been minimized.

Member

liewegas commented Jun 20, 2017

looks good.. can you squash back into 1 commit please?

test/osd: Removed Commented Code - 2
Removed commented code found in test/osd/.

Fixes: http://tracker.ceph.com/issues/20207 (Partially)

Signed-off-by: Jos Collin <jcollin@redhat.com>
@joscollin

This comment has been minimized.

Member

joscollin commented Jun 20, 2017

@liewegas squashed.

@liewegas liewegas merged commit 2e2e8eb into ceph:master Jun 20, 2017

3 of 4 checks passed

arm64 make check arm64 make check started
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@joscollin joscollin deleted the joscollin:wip-cleanup-test-commented-code-2 branch Jun 20, 2017

@amitkumar50

Irrelevant code is removed.
Changes are good.

@joscollin joscollin removed the needs-review label Oct 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment