New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw_file: replace raw fs->fh_lru.unref with predefined fs->unref #15541

Merged
merged 1 commit into from Jun 9, 2017

Conversation

Projects
None yet
2 participants
@guihecheng
Contributor

guihecheng commented Jun 7, 2017

Cleanup for conciseness, also removes a ref on root_fh which does nothing.

Signed-off-by: Gui Hecheng guihecheng@cmss.chinamobile.com

Gui Hecheng
rgw_file: replace raw fs->fh_lru.unref with predefined fs->unref
Cleanup for conciseness, also removes a ref on root_fh which does nothing.

Signed-off-by: Gui Hecheng <guihecheng@cmss.chinamobile.com>
@mattbenjamin

This comment has been minimized.

Contributor

mattbenjamin commented Jun 7, 2017

@guihecheng cleanup is great; as regards unref of root_fh, though; is it potentially valuable to keep its count updated as a check?

@guihecheng

This comment has been minimized.

Contributor

guihecheng commented Jun 8, 2017

@mattbenjamin as I read, the ref() will skip a count update on a root_fh ? because root_fh is never in lru.

@mattbenjamin mattbenjamin self-assigned this Jun 8, 2017

@mattbenjamin

ok, lgtm, will test

@mattbenjamin

lgtm, tested

@mattbenjamin mattbenjamin merged commit 05a390b into ceph:master Jun 9, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment