New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common,osdc: remove atomic_t completely #15562

Merged
merged 9 commits into from Jun 9, 2017

Conversation

Projects
None yet
4 participants
@tchaikov
Contributor

tchaikov commented Jun 8, 2017

No description provided.

common/ceph_context: s/atomic_t/std::atomic<>/
Signed-off-by: Kefu Chai <kchai@redhat.com>

tchaikov added some commits Jun 8, 2017

osdc/Objecter: s/atomic_t/std::atomic<>/
Signed-off-by: Kefu Chai <kchai@redhat.com>
msg,common: do not include assert.h everywhere to clobber <assert.h>
* reverts c93daaf
* add "#include "include/assert.h" to where <cassert> or <assert.h> are
  included, or avoid including them if possible.

Signed-off-by: Kefu Chai <kchai@redhat.com>
rgw: rgw_rados: s/atomic_t/atomic<>/
Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov changed the title from common,osdc: use std::atomic<> instead of atomic_t to common,osdc: remove atomic_t completely Jun 8, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jun 8, 2017

@chardan guess it's the final nail in the coffin of atomic_t in ceph.

@tchaikov tchaikov requested review from liewegas and cbodley Jun 8, 2017

msg/async: s/atomic_t/atomic<>/
Signed-off-by: Kefu Chai <kchai@redhat.com>
@joscollin

This comment has been minimized.

Member

joscollin commented Jun 8, 2017

@tchaikov
/home/jenkins-build/build/workspace/ceph-pull-requests/src/journal/JournalRecorder.h:8:28: fatal error: include/atomic.h: No such file or directory

tchaikov added some commits Jun 8, 2017

msg,client,os,journal: do not include unused header
Signed-off-by: Kefu Chai <kchai@redhat.com>
cmake,debian,rpm: remove atomic_t completely
Signed-off-by: Kefu Chai <kchai@redhat.com>
client: s/atomic_t/std::atomic<>
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jun 8, 2017

@joscollin fixed in latest version.

tools/rbd_mirror: do not include ununsed header
Signed-off-by: Kefu Chai <kchai@redhat.com>
@liewegas

YAY!

@liewegas liewegas added the needs-qa label Jun 8, 2017

@chardan

This comment has been minimized.

Contributor

chardan commented Jun 8, 2017

Whew!! :-)

@liewegas liewegas merged commit c2e346c into ceph:master Jun 9, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodifed Submodules submodules for project are unmodified
Details
default Build finished.
Details

@tchaikov tchaikov deleted the tchaikov:wip-no-assert.h branch Jun 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment