New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress crash bug refactor #15569

Merged
merged 3 commits into from Jun 26, 2017

Conversation

Projects
None yet
4 participants
@aclamk
Contributor

aclamk commented Jun 8, 2017

This is a refactor of pull request #15335 .
Logic simplified, now rgw_compression produces chunks of size exactly rgw_max_chunk_size.

{
CompressorRef plugin;
plugin = Compressor::create(g_ceph_context, Compressor::COMP_ALG_ZLIB);
ASSERT_NE(plugin.get(), nullptr);

This comment has been minimized.

@cbodley

cbodley Jun 12, 2017

Contributor

i think this depends on the test being able to locate a valid ceph.conf. without one, this assertion fails

test_async_compressor.cc, for example, has to set plugin_dir explicitly in order to run as part of make check. could you try that here?

This comment has been minimized.

@aclamk

aclamk Jun 14, 2017

Contributor

@cbodley
Actually, logic for setting plugin_dir is already there. It comes from src/test/unit.cc.
https://github.com/ceph/ceph/blob/master/src/test/unit.cc#L44-L48
There is difference in linking between test_rgw_compression.cc and test_async_compressor.cc

This comment has been minimized.

@aclamk

aclamk Jun 14, 2017

Contributor

@cbodley
What I can do, I can add logic to use ".libs" if CEPH_LIB is not set. Should I?

This comment has been minimized.

@cbodley

cbodley Jun 14, 2017

Contributor

oh cool, i didn't see that in src/test/unit.cc. that should be good enough

@cbodley

looks good, will merge once i can get a clean teuthology run

@cbodley

This comment has been minimized.

@cbodley

This comment has been minimized.

Contributor

cbodley commented Jun 19, 2017

jenkins test this please

3 similar comments
@cbodley

This comment has been minimized.

Contributor

cbodley commented Jun 20, 2017

jenkins test this please

@aclamk

This comment has been minimized.

Contributor

aclamk commented Jun 22, 2017

jenkins test this please

@cbodley

This comment has been minimized.

Contributor

cbodley commented Jun 22, 2017

jenkins test this please

@cbodley

This comment has been minimized.

Contributor

cbodley commented Jun 23, 2017

@aclamk needs rebase again :(

fangyuxiangGL and others added some commits May 27, 2017

rgw: connection reset/crashed when download large zero object with co…
…mpression enable

large zero object has a large compression rate,
even 4M compressed data can decompress several GB data.
Handle so much data in single process lead strange issue.

Fixes: http://tracker.ceph.com/issues/20098

Signed-off-by: fang yuxiang fang.yuxiang@eisoo.com
radosgw, compression: added unit test
Signed-off-by: Adam Kupczyk <akupczyk@mirantis.com>
radosgw: refactor compression code
Signed-off-by: Adam Kupczyk <akupczyk@mirantis.com>

@cbodley cbodley merged commit e3d5960 into ceph:master Jun 26, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
default Build finished.
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment