Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools/cephfs: fix cephfs-journal-tool --help #15614

Merged
merged 1 commit into from Jun 19, 2017

Conversation

Projects
None yet
2 participants
@jcsp
Copy link
Contributor

jcsp commented Jun 11, 2017

The --alternate-pool option was in the wrong place.

Signed-off-by: John Spray john.spray@redhat.com

@jcsp jcsp requested a review from fullerdj Jun 11, 2017

@fullerdj
Copy link
Contributor

fullerdj left a comment

So, I think "output" here implies the text output to the console, not the data output into RADOS. I don't think this should be changed.

@jcsp

This comment has been minimized.

Copy link
Contributor Author

jcsp commented Jun 13, 2017

Ah, I was going on where the option was parsed. It just has to be last, right? So maybe we just put it out there on its own. Pretty sure it doesn't belong in the list of selectors though.

John Spray
tools/cephfs: fix cephfs-journal-tool --help
The --alternate-pool option was in the wrong place.

This format is not beautiful, but I think it's accurate
in terms of where the option should sit to get parsed
correctly?

Signed-off-by: John Spray <john.spray@redhat.com>

@jcsp jcsp force-pushed the jcsp:wip-jt-help branch from 4d80c57 to 80612a5 Jun 15, 2017

@jcsp

This comment has been minimized.

Copy link
Contributor Author

jcsp commented Jun 15, 2017

@fullerdj updated, let's do this unless there's a neat alternative?

@jcsp jcsp merged commit abb6580 into ceph:master Jun 19, 2017

2 of 4 checks passed

arm64 make check arm64 make check failed
Details
make check make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details

@jcsp jcsp deleted the jcsp:wip-jt-help branch Jun 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.