New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/PyFormatter: implement dump_format_va #15634

Merged
merged 1 commit into from Jun 12, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented Jun 12, 2017

Signed-off-by: Sage Weil sage@redhat.com

mgr/PyFormatter: implement dump_format_va
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas requested a review from jcsp Jun 12, 2017

@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Jun 12, 2017

@liewegas It would be better if you could add Fixes: http://tracker.ceph.com/issues/20245 to commit message. 😄

I was impressed with the simplicity of supporting dump_format_va. I have took some time to figure out how to process ns and quoted parameters.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jun 12, 2017

better off fixing the dump_float() method, IMO. @Liuchang0812 i think sage's fix is better than yours. as its output looks better: "percent used: 12.34". what do you think?

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jun 12, 2017

@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Jun 12, 2017

yes! I prefer this one.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jun 12, 2017

 91/173 Test   #5: cephtool-test-mon.sh ....................   Passed  270.28 sec

@tchaikov tchaikov merged commit efb1c30 into ceph:master Jun 12, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@liewegas liewegas deleted the liewegas:wip-pyformatter branch Jun 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment