Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph_test_rados_api_*: wait for snap trim on ENOENT during cleanup #15638

Merged
merged 1 commit into from Jun 13, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Copy link
Member

liewegas commented Jun 12, 2017

@liewegas liewegas changed the title qa/upgrade/jewel-x/point-to-point: add a mgr during final upgrade ceph_test_rados_api_*: wait for snap trim on ENOENT during cleanup Jun 12, 2017

ceph_test_rados_api_*: wait for snap trim on ENOENT during cleanup
Assume that an ENOENT removing an object during cleanup means the
head is a whiteout because there are clones.  When that happens
just sleep for a bit and then retry in the hopes that snap
trimming has happened.

Time out (and fail) after retrying for 10 minutes' worth of tries.

Fixes: http://tracker.ceph.com/issues/19948
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas force-pushed the liewegas:wip-19948 branch from 2f0a4c2 to 4302237 Jun 12, 2017

@liewegas

This comment has been minimized.

Copy link
Member Author

liewegas commented Jun 12, 2017

Managed to reproduce this with osd_snap_trim_sleep = 1, and this resolved it!

@liewegas liewegas requested a review from dzafman Jun 12, 2017

@badone

badone approved these changes Jun 13, 2017

Copy link
Contributor

badone left a comment

LFTM

@tchaikov
Copy link
Contributor

tchaikov left a comment

yeah, it's a luminous behavior. by default, we need to remove all clones before removing the head.

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Jun 13, 2017

merging since all tests involving rados_api_tests.yaml passed in above run.

@tchaikov tchaikov merged commit 3048d94 into ceph:master Jun 13, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.