New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config_opt: use bool instead of int for the default value of filestore_debug_omap_check #15651

Merged
merged 1 commit into from Jun 20, 2017

Conversation

Projects
None yet
3 participants
@zealoussnow
Contributor

zealoussnow commented Jun 13, 2017

Signed-off-by: Leo Zhang nguzcf@gmail.com

filestore: fix filestore_debug_omap_check option to a default bool value
Signed-off-by: Leo Zhang <nguzcf@gmail.com>
@@ -1223,7 +1223,7 @@ OPTION(filestore_index_retry_probability, OPT_DOUBLE, 0)
// Allow object read error injection
OPTION(filestore_debug_inject_read_err, OPT_BOOL, false)
OPTION(filestore_debug_omap_check, OPT_BOOL, 0) // Expensive debugging check on sync
OPTION(filestore_debug_omap_check, OPT_BOOL, false) // Expensive debugging check on sync

This comment has been minimized.

@tchaikov

tchaikov Jun 13, 2017

Contributor

@zealoussnow i take this as a clean up, am i right? as 0 can be evaluated to false in this context.

This comment has been minimized.

@zealoussnow

zealoussnow Jun 13, 2017

Contributor

@tchaikov yes, you are right.

@tchaikov tchaikov changed the title from filestore: fix filestore_debug_omap_check option to a default bool value to config_opt: use bool instead of int for the default value of filestore_debug_omap_check Jun 13, 2017

@liewegas liewegas added the cleanup label Jun 20, 2017

@liewegas liewegas merged commit f337b4e into ceph:master Jun 20, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@zealoussnow zealoussnow deleted the zealoussnow:wip-0613 branch Mar 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment