New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wip rgw reshard old bucket #15665

Merged
merged 2 commits into from Jun 23, 2017

Conversation

Projects
None yet
2 participants
@oritwas
Contributor

oritwas commented Jun 13, 2017

No description provided.

rgw: user const rgw_bucket in quota
Signed-off-by: Orit Wasserman <owasserm@redhat.com>

@oritwas oritwas added the rgw label Jun 13, 2017

@oritwas oritwas added this to the luminous milestone Jun 13, 2017

r = check_bucket_shards(bucket_info, bucket_info.bucket, bucket_quota);
if (r < 0) {
ldout(cct, 0) << "ERROR in check_bucket_shards: " << cpp_strerror(-r)<< dendl;
}

This comment has been minimized.

@yehudasa

yehudasa Jun 21, 2017

Member

@oritwas shouldn't have this inside the loop here, need to move it outside. Actually, I think this is the wrong method to put this in, maybe rgw_user.cc:rgw_user_sync_all_stats() is better?

rgw: check all users bucket for resharding, this will reshard bucket …
…created in older versions

Signed-off-by: Orit Wasserman <owasserm@redhat.com>
@oritwas

This comment has been minimized.

Contributor

oritwas commented Jun 22, 2017

@yehudasa , fixed please review

@yehudasa

lgtm, how did you test it?

@oritwas

This comment has been minimized.

Contributor

oritwas commented Jun 23, 2017

@yehudasa , my test:

  1. created bucket with 10 objs
    2 . rerun the gateway with --rgw-max_objs-per-shard=8 --rgw-user-quota-sync-wait-time=5 --rgw-reshard-thread-interval =5
  2. check it was put into the reshard queue
  3. check the number of the bucket shard is 2 (after it was resharded)
@oritwas

This comment has been minimized.

Contributor

oritwas commented Jun 23, 2017

jenkins test this please

@yehudasa yehudasa merged commit 90b5efa into ceph:master Jun 23, 2017

2 of 4 checks passed

arm64 make check arm64 make check failed
Details
make check make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment