New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: fix error handling in the link() method of RGWBucket. #15669

Merged
merged 1 commit into from Jul 12, 2017

Conversation

Projects
None yet
3 participants
@rzarzynski
Contributor

rzarzynski commented Jun 13, 2017

The recent Static Analysis for Ceph (linked 13 June 2017 on ceph-devel) shows that the link() method of RGWBucket assigns to a variable but doesn't use it later. The anomaly is caused by lack of proper error handling. This commit rectifies it.

Signed-off-by: Radoslaw Zarzynski rzarzynski@mirantis.com

@cbodley

This comment has been minimized.

Contributor

cbodley commented Jun 13, 2017

@rzarzynski i think this deserves a backport, could you add a ticket?

rgw: fix error handling in the link() method of RGWBucket.
The recent Static Analysis for Ceph (linked 13 June 2017 on
ceph-devel) shows that the link() method of RGWBucket assigns
to a variable but doesn't use it later. The anomaly is caused
by lack of proper error handling. This commit rectifies it.

Fixes: http://tracker.ceph.com/issues/20279
Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>

@rzarzynski rzarzynski added the bug fix label Jun 13, 2017

@rzarzynski

This comment has been minimized.

Contributor

rzarzynski commented Jun 13, 2017

@cbodley: updated.

@yuriw yuriw merged commit a20dd80 into ceph:master Jul 12, 2017

3 of 4 checks passed

make check (arm64) running make check
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment