New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw_file: fix assert upon setattr on bucket #15679

Merged
merged 1 commit into from Jun 19, 2017

Conversation

Projects
None yet
5 participants
@guihecheng
Contributor

guihecheng commented Jun 14, 2017

Gui Hecheng
rgw_file: fix assert upon setattr on bucket
Fixes: http://tracker.ceph.com/issues/20287

Signed-off-by: Gui Hecheng <guihecheng@cmss.chinamobile.com>
@ceph-jenkins

This comment has been minimized.

Collaborator

ceph-jenkins commented Jun 14, 2017

Can one of the admins verify this patch?

@mattbenjamin

This comment has been minimized.

Contributor

mattbenjamin commented Jun 14, 2017

@ceph-jenkins this happens when (on master) we're doing setattr on a bucket with nothing in it, apparently (verified)
UPDATE: I'm rechecking this, and comparing against our rhcs 2.3 branch;

@alfredodeza

This comment has been minimized.

Contributor

alfredodeza commented Jun 14, 2017

OK to test

@mattbenjamin

This comment has been minimized.

Contributor

mattbenjamin commented Jun 15, 2017

got delayed a bit, can't build downstream without LDFLAGS="-lasan" (whaaa?)

@mattbenjamin

lgtm, initially I misread where this object.empty() check takes place, and that we are not introducing it, only moving it

if (!s->object.empty()) {
store->set_atomic(s->obj_ctx, obj);

This comment has been minimized.

@mattbenjamin

mattbenjamin Jun 19, 2017

Contributor

ah, ok, this is correct, the else case calls rgw_bucket_set_attrs

@mattbenjamin mattbenjamin merged commit e7a00bc into ceph:master Jun 19, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
arm64 make check arm64 make check succeeded
Details
make check make check succeeded
Details

@guihecheng guihecheng deleted the guihecheng:rgw_file-fix-setattr branch Jun 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment