New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/OSDMap: Change *pg_to_* to return void #15684

Merged
merged 1 commit into from Jun 15, 2017

Conversation

Projects
None yet
2 participants
@badone
Contributor

badone commented Jun 14, 2017

Returning the number of items in the vector is not required and can be
calculated since the caller has access to the vector.

Signed-off-by: Brad Hubbard bhubbard@redhat.com

osd: Change *pg_to_* to return void
Returning the number of items in the vector is not required and can be
calculated since the caller has access to the vector.

Signed-off-by: Brad Hubbard <bhubbard@redhat.com>

@badone badone requested a review from liewegas Jun 14, 2017

@badone

This comment has been minimized.

Contributor

badone commented Jun 14, 2017

@liewegas is this what you meant? Did I miss any?

@liewegas liewegas changed the title from osd: Change *pg_to_* to return void to osd/OSDMap: Change *pg_to_* to return void Jun 14, 2017

@liewegas

perfect!

@badone badone removed the needs-qa label Jun 15, 2017

@badone badone merged commit 15a9b59 into ceph:master Jun 15, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
arm64 make check arm64 make check succeeded
Details
make check make check succeeded
Details

@badone badone deleted the badone:wip-refactor-of-osdmap-methods branch Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment